Stubsabot: mark stubs as obsolete, even if the py.typed file was added in a micro version#10368
Merged
Merged
Conversation
…ded in a micro version
sobolevn
approved these changes
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flake8-plugin-utils released a new version with a
py.typedfile yesterday. However, stubsabot didn't file a PR to mark our stubs for flake8-plugin-utils as obsolete, because thepy.typedfile was added in v1.3.3. Our stubs are pinned to1.3.*:typeshed/stubs/flake8-plugin-utils/METADATA.toml
Line 1 in 93b4060
This led stubsabot to conclude that our stubs were up to date with the runtime package, so stubsabot exited early from the
determine_actionfunction before it even got to the bit where we try to figure out if the stubs package is obsolete or not.